Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor_change] add support for configuration of vrf multicast with ac… #525

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

akinross
Copy link
Collaborator

@akinross akinross commented Nov 4, 2023

…i_vrf_multicast module

This is a single module (aci_access_switch_policy_group) from a larger PR of tim cragg #419

Splitting up the module for easier review

@akinross akinross added the enhancement New feature or request label Nov 4, 2023
@akinross akinross self-assigned this Nov 4, 2023
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Attention: 92 lines in your changes are missing coverage. Please review.

Comparison is base (6a9e854) 35.69% compared to head (0c5bc1a) 35.68%.

❗ Current head 0c5bc1a differs from pull request most recent head 95f16db. Consider uploading reports for the commit 95f16db to get more accurate results

Files Patch % Lines
plugins/modules/aci_vrf_multicast.py 17.11% 92 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
- Coverage   35.69%   35.68%   -0.02%     
==========================================
  Files         201      201              
  Lines        9211     9220       +9     
  Branches     1362     1365       +3     
==========================================
+ Hits         3288     3290       +2     
- Misses       5923     5930       +7     
Flag Coverage Δ
sanity 35.68% <17.85%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

plugins/modules/aci_vrf_multicast.py Outdated Show resolved Hide resolved
plugins/modules/aci_vrf_multicast.py Outdated Show resolved Hide resolved
plugins/modules/aci_vrf_multicast.py Outdated Show resolved Hide resolved
plugins/modules/aci_vrf_multicast.py Outdated Show resolved Hide resolved
plugins/modules/aci_vrf_multicast.py Show resolved Hide resolved
@akinross akinross requested a review from shrsr November 7, 2023 22:26
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes Nov 8, 2023
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmicol gmicol self-requested a review November 13, 2023 18:51
gmicol
gmicol previously approved these changes Nov 13, 2023
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot previously approved these changes Nov 17, 2023
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot dismissed stale reviews from gmicol, shrsr, and themself via 95f16db November 17, 2023 00:55
@lhercot lhercot force-pushed the tim_cragg_vrf_multicast branch from 4a6640e to 95f16db Compare November 17, 2023 00:55
@lhercot lhercot merged commit 3827fb7 into CiscoDevNet:master Nov 17, 2023
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants