Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor_change] update aci_interface_config with the correct minimum v… #522

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

akinross
Copy link
Collaborator

@akinross akinross commented Nov 3, 2023

…ersion of 5.2(7)

@akinross akinross self-assigned this Nov 3, 2023
@akinross akinross added the documentation Improvements or additions to documentation label Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 157 lines in your changes are missing coverage. Please review.

Comparison is base (1474956) 96.65% compared to head (c91c9fc) 35.90%.
Report is 11 commits behind head on master.

❗ Current head c91c9fc differs from pull request most recent head 14b8f3e. Consider uploading reports for the commit 14b8f3e to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #522       +/-   ##
===========================================
- Coverage   96.65%   35.90%   -60.76%     
===========================================
  Files         192      200        +8     
  Lines        8823     9108      +285     
  Branches     1307     1335       +28     
===========================================
- Hits         8528     3270     -5258     
- Misses        222     5838     +5616     
+ Partials       73        0       -73     
Flag Coverage Δ
integration ?
sanity 35.90% <44.91%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plugins/modules/aci_interface_config.py 28.78% <ø> (-71.22%) ⬇️
plugins/modules/aci_match_rule.py 51.61% <51.61%> (ø)
plugins/modules/aci_match_community_term.py 50.00% <50.00%> (ø)
plugins/modules/aci_match_as_path_regex_term.py 48.48% <48.48%> (ø)
plugins/modules/aci_match_community_factor.py 47.05% <47.05%> (ø)
plugins/modules/aci_match_community_regex_term.py 47.05% <47.05%> (ø)
plugins/modules/aci_match_route_destination.py 45.71% <45.71%> (ø)
plugins/modules/aci_route_control_profile.py 42.10% <42.10%> (ø)
plugins/modules/aci_route_control_context.py 33.33% <33.33%> (ø)

... and 186 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 684a8cb into CiscoDevNet:master Nov 4, 2023
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants