[minor_change] add support for configuration of fabric pod selectors … #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinross
requested review from
lhercot,
shrsr,
anvitha-jain,
sajagana,
samiib and
gmicol
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #509 +/- ##
==========================================
- Coverage 35.51% 35.51% -0.01%
==========================================
Files 189 190 +1
Lines 8694 8751 +57
Branches 1287 1300 +13
==========================================
+ Hits 3088 3108 +20
- Misses 5606 5643 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
samiib
requested changes
Oct 27, 2023
|
Need a rebase |
…with aci_fabric_pod_selector module
lhercot
dismissed stale reviews from samiib, anvitha-jain, and themself
via
cb22a8b
lhercot
force-pushed
the
tim_cragg_fabric_pod_selector
branch
from
a5d379e to
cb22a8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…with aci_fabric_pod_selector module
This is a single module (aci_fabric_pod_selector) from a larger PR of tim cragg #419
Splitting up the module for easier review