Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor_change] add support for configuration of fabric node control w… #503

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

akinross
Copy link
Collaborator

…ith aci_fabric_node_control module

This is a single module (aci_fabric_node_control) from a larger PR of tim cragg #419

Splitting up the module for easier review

@akinross akinross added the enhancement New feature or request label Oct 23, 2023
@akinross akinross self-assigned this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 75 lines in your changes are missing coverage. Please review.

Comparison is base (96dddfe) 96.52% compared to head (9c1f5d6) 35.40%.
Report is 7 commits behind head on master.

❗ Current head 9c1f5d6 differs from pull request most recent head b505d25. Consider uploading reports for the commit b505d25 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #503       +/-   ##
===========================================
- Coverage   96.52%   35.40%   -61.12%     
===========================================
  Files         183      187        +4     
  Lines        8479     8622      +143     
  Branches     1265     1279       +14     
===========================================
- Hits         8184     3053     -5131     
- Misses        222     5569     +5347     
+ Partials       73        0       -73     
Flag Coverage Δ
integration ?
sanity 35.40% <47.55%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plugins/module_utils/constants.py 100.00% <100.00%> (ø)
plugins/modules/aci_l3out_logical_node_profile.py 48.48% <ø> (-51.52%) ⬇️
plugins/modules/aci_snmp_user.py 45.45% <0.00%> (-54.55%) ⬇️
plugins/modules/aci_fabric_node_control.py 51.61% <51.61%> (ø)
plugins/modules/aci_bgp_best_path_policy.py 51.51% <51.51%> (ø)
plugins/modules/aci_bgp_timers_policy.py 45.94% <45.94%> (ø)
plugins/modules/aci_l3out_bgp_protocol_profile.py 41.02% <41.02%> (ø)

... and 176 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akinross akinross requested a review from samiib October 24, 2023 06:00
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit a82f929 into CiscoDevNet:master Oct 31, 2023
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants