-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minor_change] add support for configuration of system banner and ali… #499
[minor_change] add support for configuration of system banner and ali… #499
Conversation
…as with aci_system_banner module
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #499 +/- ##
===========================================
- Coverage 96.52% 35.40% -61.12%
===========================================
Files 183 187 +4
Lines 8479 8626 +147
Branches 1265 1278 +13
===========================================
- Hits 8184 3054 -5130
- Misses 222 5572 +5350
+ Partials 73 0 -73
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
plugins/modules/aci_system_banner.py
Outdated
host: apic | ||
username: admin | ||
password: SomeSecretPassword | ||
name: ans_remote_path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably shouldn't be name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
…as with aci_system_banner module
This is a single module (aci_pre_login_banner) from a larger PR of tim cragg #419
Splitting up the module for easier review