Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor_changes] Added BFD Multihop Interface policy (bfdMhIfPol) class. #492

Merged
merged 10 commits into from
Dec 20, 2023
Merged

[minor_changes] Added BFD Multihop Interface policy (bfdMhIfPol) class. #492

merged 10 commits into from
Dec 20, 2023

Conversation

anvitha-jain
Copy link
Collaborator

No description provided.

@anvitha-jain anvitha-jain self-assigned this Oct 9, 2023
@anvitha-jain anvitha-jain linked an issue Oct 9, 2023 that may be closed by this pull request
aci_bfd_multihop classes. #493
Closed
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Attention: 143 lines in your changes are missing coverage. Please review.

Comparison is base (910e70d) 96.30% compared to head (832f485) 35.32%.
Report is 69 commits behind head on master.

Files Patch % Lines
...odules/aci_l3out_bfd_multihop_interface_profile.py 33.33% 30 Missing ⚠️
plugins/modules/aci_l3out_bfd_interface_profile.py 34.09% 29 Missing ⚠️
plugins/modules/aci_bfd_multihop_node_policy.py 34.88% 28 Missing ⚠️
plugins/modules/aci_interface_policy_bfd.py 34.88% 28 Missing ⚠️
...ugins/modules/aci_interface_policy_bfd_multihop.py 34.88% 28 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #492       +/-   ##
===========================================
- Coverage   96.30%   35.32%   -60.99%     
===========================================
  Files         210      230       +20     
  Lines        9720    10610      +890     
  Branches     1447     1591      +144     
===========================================
- Hits         9361     3748     -5613     
- Misses        277     6862     +6585     
+ Partials       82        0       -82
Flag Coverage Δ
integration ?
sanity 35.32% <34.40%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anvitha-jain anvitha-jain force-pushed the bfd_multihop branch 2 times, most recently from 54bea69 to 12b6895 Compare November 3, 2023 07:34
akinross
akinross requested changes Nov 6, 2023
View reviewed changes
tests/integration/targets/aci_bfd_multihop_interface_profile/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/aci_bfd_multihop_interface_profile/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/aci_bfd_interface_policy/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/aci_bfd_interface_policy/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/aci_bfd_interface_policy/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/aci_l3out_bfd_interface_profile/tasks/main.yml Show resolved Hide resolved
tests/integration/targets/aci_bfd_multihop_interface_policy/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/aci_bfd_multihop_interface_policy/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/aci_bfd_multihop_interface_profile/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/aci_bfd_multihop_node_policy/tasks/main.yml Show resolved Hide resolved
@akinross
Copy link
Collaborator

akinross commented Nov 6, 2023

please fix sanity checks

@anvitha-jain anvitha-jain force-pushed the bfd_multihop branch 3 times, most recently from 3d4e551 to 3fec0fb Compare November 8, 2023 19:11
samiib
samiib previously approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross requested changes Nov 9, 2023
View reviewed changes
plugins/modules/aci_bfd_multihop_interface_profile.py Outdated Show resolved Hide resolved
plugins/modules/aci_bfd_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/aci_bfd_multihop_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/aci_bfd_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/aci_bfd_interface_policy.py Outdated Show resolved Hide resolved
plugins/modules/aci_bfd_multihop_interface_profile.py Outdated Show resolved Hide resolved
plugins/modules/aci_bfd_multihop_node_policy.py Outdated Show resolved Hide resolved
plugins/modules/aci_l3out_bfd_interface_profile.py Outdated Show resolved Hide resolved
plugins/modules/aci_l3out_bfd_interface_profile.py Outdated Show resolved Hide resolved
plugins/modules/aci_l3out_bfd_interface_profile.py Outdated Show resolved Hide resolved
@anvitha-jain anvitha-jain force-pushed the bfd_multihop branch 2 times, most recently from f4f4700 to ade8425 Compare November 22, 2023 00:27
akinross
akinross previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gmicol
gmicol previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr requested changes Dec 1, 2023
View reviewed changes
plugins/modules/aci_interface_policy_bfd.py Outdated Show resolved Hide resolved
plugins/modules/aci_interface_policy_bfd.py Outdated Show resolved Hide resolved
plugins/modules/aci_interface_policy_bfd_multihop.py Outdated Show resolved Hide resolved
plugins/modules/aci_interface_policy_bfd_multihop.py Outdated Show resolved Hide resolved
plugins/modules/aci_interface_policy_bfd_multihop.py Outdated Show resolved Hide resolved
@anvitha-jain anvitha-jain dismissed stale reviews from gmicol, sajagana, and akinross via 1f2b32e December 1, 2023 17:58
shrsr
shrsr previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Dec 1, 2023
View reviewed changes
sajagana
sajagana previously approved these changes Dec 2, 2023
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

samiib
samiib previously approved these changes Dec 3, 2023
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anvitha-jain anvitha-jain dismissed stale reviews from akinross, samiib, sajagana, gmicol, and shrsr via 832f485 December 20, 2023 17:26
@anvitha-jain anvitha-jain requested a review from lhercot December 20, 2023 17:26
lhercot
lhercot approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 61b0904 into CiscoDevNet:master Dec 20, 2023
17 of 23 checks passed
@gmicol
Copy link
Collaborator

gmicol commented Dec 21, 2023

is part of issue #126

@gmicol gmicol mentioned this pull request Dec 21, 2023
Closed
@anvitha-jain anvitha-jain deleted the bfd_multihop branch March 13, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhercot lhercot lhercot approved these changes

@gmicol gmicol gmicol left review comments

@samiib samiib samiib left review comments

@sajagana sajagana sajagana left review comments

@akinross akinross akinross left review comments

@shrsr shrsr shrsr left review comments

Assignees

@anvitha-jain anvitha-jain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aci_bfd_multihop classes.
7 participants
@anvitha-jain @akinross @gmicol @lhercot @shrsr @sajagana @samiib