[minor_change] Add loopback interface profile as a child class for ac… #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i_l3out_logical_node.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
==========================================
- Coverage 96.53% 96.52% -0.02%
==========================================
Files 183 183
Lines 8430 8458 +28
Branches 1248 1260 +12
==========================================
+ Hits 8138 8164 +26
- Misses 221 222 +1
- Partials 71 72 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
gmicol
requested review from
lhercot,
shrsr,
akinross,
anvitha-jain and
sajagana
…ck interface profile.
akinross
requested changes
Sep 18, 2023
tests/integration/targets/aci_l3out_logical_node/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/aci_l3out_logical_node/tasks/main.yml
Outdated
Show resolved
Hide resolved
|
Sanity test and black formatting is failing. |
…or aci_l3out_logical_node.
akinross
requested changes
Sep 20, 2023
shrsr
requested changes
Sep 21, 2023
anvitha-jain
requested changes
Sep 21, 2023
tests/integration/targets/aci_l3out_logical_node/tasks/main.yml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is part of issue #126