-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gsoc'24): project offline save functionality #370
Conversation
WalkthroughThe recent changes include updates to the state management in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for circuitverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/simulator/src/node.js
Outdated
@@ -255,7 +255,7 @@ | |||
* function for saving a node | |||
*/ | |||
saveObject() { | |||
if (this.type == NODE_INTERMEDIATE2) { | |||
if (this.type == NODE_INTERMEDIATE) { |
Check failure
Code scanning / ESLint
disallow the use of undeclared variables unless mentioned in `/*global */` comments Error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- src/components/DialogBox/OpenOffline.vue (1 hunks)
- src/simulator/src/data/project.ts (1 hunks)
- src/simulator/src/node.js (1 hunks)
Additional context used
GitHub Check: ESLint
src/simulator/src/node.js
[failure] 258-258: disallow the use of undeclared variables unless mentioned in
/*global */
comments
'NODE_INTERMEDIATE' is not defined.
Additional comments not posted (3)
src/components/DialogBox/OpenOffline.vue (2)
68-68
: LGTM!The removal of the
reactive
import is consistent with the change in howprojectList
is defined.The code changes are approved.
70-71
: LGTM!The change to use
ref
forprojectList
simplifies the reactivity model and is appropriate given the context.The code changes are approved.
src/simulator/src/data/project.ts (1)
96-96
: Verify the type ofdata
being stored inlocalStorage
.The removal of the serialization step could lead to potential issues if
data
is not a string, aslocalStorage
typically requires string values. Ensure thatdata
is always a string before storing it inlocalStorage
.Run the following script to verify the type of
data
being stored inlocalStorage
:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/simulator/src/data/project.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/simulator/src/data/project.ts
resolves bugs from previous PRs for Offline Save functionality
Summary by CodeRabbit
New Features
Bug Fixes