786 update node to version 20 #787
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile opening app in browser
mikozet
force-pushed
the
786-update-node-to-version-20
branch
from
aa194e7
to
43888e8
Compare
✅ Deploy Preview for preview-testing-circles-garden ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Current state: Repo updated to node version 20 - compiles in terminal correctly. Tested positively functionalities of app without any errors in preview-test environment. Running tests produces error although: Proposed fix presented here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still work in progress...
Update node to version 20 was made. (first commit) with correct compile but error in web browser console.
I have choosen a path to try to resolve it with Webpack update
Update Webpack to version 5 was made (rest commits)
Current state (last commit)
Compiles correctly but with warnings in console terminal as well as in console in browser.
Screens below:
Steps to consider:
Try to resolve json-loader problem in current state or go back to first commit where only update to node version 20 was made and resolve from there without webpack update..