Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use realpath for the Gemfile path. #151

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Use realpath for the Gemfile path. #151

merged 3 commits into from
Sep 30, 2024

Conversation

marboledacci
Copy link
Contributor

As indicated in #122 when the PARAM_GEMFILE is set to Gemfile by default, and setting it might cause issues when a command is executed in a different directory. This PR is intented to fix that behavior.

@marboledacci marboledacci requested a review from a team as a code owner September 27, 2024 18:22
@marboledacci marboledacci changed the title Issue 122 Use realpath for the Gemfile path. Sep 27, 2024
@marboledacci marboledacci merged commit 3a11bf1 into master Sep 30, 2024
2 checks passed
@marboledacci marboledacci deleted the issue-122 branch September 30, 2024 14:23
@orb-publisher
Copy link

Your orb has been published to the CircleCI Orb Registry.
You can view your published orb on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/ruby?version=2.2.1

@rwojsznis
Copy link

FYI ppl coming from the internet here - this changes breaks previous behavior when specifying gemfile: Gemfile.next for next_rails setup - as the next file is a symlink

workaround is to stick with 2.2.0 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants