Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use codecov directly; change upload job so it will try to send covera… #338

Closed
wants to merge 1 commit into from

Conversation

brenol
Copy link

@brenol brenol commented Oct 4, 2019

Here are some helpful tips you can follow when submitting a pull request:

  1. Fork the repository and create your branch from master.
  2. Run make build in the repository root.
  3. If you've fixed a bug or added code that should be tested, add tests!
  4. Ensure the test suite passes (make test).
  5. The --debug flag is often helpful for debugging HTTP client requests and responses.
  6. Format your code with gofmt.
  7. Make sure your code lints (make lint). Note: This requires Docker to run inside a local job.

If you have any questions, feel free to ping us at @CircleCI-Public/x-team.

This should improve the problem that is happening in #323

@brenol brenol requested a review from a team as a code owner October 4, 2019 03:10
@hannahhenderson
Copy link
Contributor

Hi @brenol, issue #323 is officially closed, so I'm going to go ahead and close this PR.

Thank you for linking to the issue in your original PR.

@AmyScript
Copy link

@brenol If you do want to make a separate PR to use the latest codecov orb, you will also need to include in your PR a .codecov.yml or else the orb will not work and it will fail CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants