Fixed a bug that caused items to exist past the length of the bag fra…

…me (hopefully!)
Cidan · Dec 1, 2023 · f7a8448 · f7a8448
1 parent c4c984b
commit f7a8448
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/frames/column.lua b/frames/column.lua
@@ -113,7 +113,7 @@ function columnProto:Draw(style)
       else
         local first = firstCellInRow[#rows]
         cell.frame:SetPoint("TOPLEFT", first.frame, "BOTTOMLEFT", 0, -4)
-        h = h + cell.frame:GetHeight()
+        h = h + cell.frame:GetHeight() + 4
         local newRow = #rows + 1
         rows[newRow] = {count = cell:GetCellCount(), cells = {cell --[[@as Section]]}}
         cellToRow[cell] = newRow

diff --git a/views/gridview.lua b/views/gridview.lua
@@ -157,6 +157,8 @@ function views:GridView(bag, dirtyItems)
     h = 40
   end
   bag.content:HideScrollBar()
+  --TODO(lobato): Implement SafeSetSize that prevents the window from being larger
+  -- than the screen space.
   bag.frame:SetWidth(w + 12)
   bag.frame:SetHeight(h + 24 + bag.leftHeader:GetHeight() + bag.bottomBar:GetHeight())
 end