Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes SystemParametersInfoForDpi for Windows XP and 2000 #104

Closed

Conversation

lygstate
Copy link
Contributor

uiParam should also decreased

#90

修正

SystemParametersInfoW(A)
SPI_GETNONCLIENTMETRICS,Windows XP需要主动减去 iPaddedBorderWidth

@mingkuang-Chuyu
Copy link
Collaborator

感谢您的PR。其实我有个疑问,为什么不直接处理SystemParametersInfoW?因为SystemParametersInfoForDpi的fallback也是通过调用SystemParametersInfoW完成的。只要Thunk SystemParametersInfoW修正那么SystemParametersInfoForDpi也将间接修复。

@lygstate
Copy link
Contributor Author

lygstate commented Jun 28, 2024

感谢您的PR。其实我有个疑问,为什么不直接处理SystemParametersInfoW?因为SystemParametersInfoForDpi的fallback也是通过调用SystemParametersInfoW完成的。只要Thunk SystemParametersInfoW修正那么SystemParametersInfoForDpi也将间接修复。

oh 因为我发现问题的地方是在这个函数,那我改下修正的地方,
oh 发现了,是因为 SystemParametersInfoW 没有 Thunks

@lygstate lygstate force-pushed the SystemParametersInfoForDpi-fix branch from 6c2a141 to b6a07c9 Compare June 30, 2024 08:44
@lygstate
Copy link
Contributor Author

这是剩下的一个问题,当 dpi 为0,返回的内容都为0,并不是预期的

@mingkuang-Chuyu
Copy link
Collaborator

mingkuang-Chuyu commented Jun 30, 2024 via email

@lygstate lygstate closed this Jun 30, 2024
@lygstate lygstate deleted the SystemParametersInfoForDpi-fix branch June 30, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants