Skip to content

Commit

Permalink
Adding messaging.rabbitmq.message.delivery_tag to the list of Rabbi…
Browse files Browse the repository at this point in the history
…tMQ specific tags (open-telemetry#433)

Co-authored-by: Liudmila Molkova <[email protected]>
  • Loading branch information
stebet and lmolkova authored Feb 22, 2024
1 parent 1e7bb0e commit 096596b
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .chloggen/433.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
change_type: enhancement
component: messaging
note: Add `messaging.rabbitmq.message.delivery_tag`` to the list of RabbitMQ specific tags
issues: [433]
1 change: 1 addition & 0 deletions docs/attributes-registry/messaging.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ size should be used.
| Attribute | Type | Description | Examples |
|---|---|---|---|
| `messaging.rabbitmq.destination.routing_key` | string | RabbitMQ message routing key. | `myKey` |
| `messaging.rabbitmq.message.delivery_tag` | int | RabbitMQ message delivery tag | `123` |
<!-- endsemconv -->

## RocketMQ Attributes
Expand Down
1 change: 1 addition & 0 deletions docs/messaging/rabbitmq.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ In RabbitMQ, the destination is defined by an *exchange* and a *routing key*.
| Attribute | Type | Description | Examples | Requirement Level |
|---|---|---|---|---|
| [`messaging.rabbitmq.destination.routing_key`](../attributes-registry/messaging.md) | string | RabbitMQ message routing key. | `myKey` | Conditionally Required: If not empty. |
| [`messaging.rabbitmq.message.delivery_tag`](../attributes-registry/messaging.md) | int | RabbitMQ message delivery tag | `123` | Conditionally Required: When available. |
<!-- endsemconv -->

[DocumentStatus]: https://github.com/open-telemetry/opentelemetry-specification/tree/v1.26.0/specification/document-status.md
7 changes: 7 additions & 0 deletions model/registry/messaging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,13 @@ groups:
RabbitMQ message routing key.
examples: 'myKey'
tag: tech-specific-rabbitmq
- id: rabbitmq.message.delivery_tag
type: int
brief: >
RabbitMQ message delivery tag
examples: 123
tag: tech-specific-rabbitmq

- id: rocketmq.client_group
type: string
brief: >
Expand Down
4 changes: 4 additions & 0 deletions model/trace/messaging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ groups:
requirement_level:
conditionally_required: If not empty.
tag: tech-specific-rabbitmq
- ref: messaging.rabbitmq.message.delivery_tag
requirement_level:
conditionally_required: When available.
tag: tech-specific-rabbitmq

- id: messaging.kafka
type: attribute_group
Expand Down

0 comments on commit 096596b

Please sign in to comment.