Fixed static analysis issues

ChristianPanov · Nov 8, 2024 · 637f0b0 · 637f0b0
1 parent 3694179
commit 637f0b0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/lwlog/src/details/os/time_point_impl.h b/lwlog/src/details/os/time_point_impl.h
@@ -21,7 +21,7 @@ namespace lwlog::details::os
 			minute 	= m_now.wMinute;
 			second 	= m_now.wSecond;
 
-			hour = datetime::handle_timezone<LocalTimePolicy>(m_now.wHour);
+			hour = datetime::handle_timezone<LocalTimePolicy>(static_cast<std::uint8_t>(m_now.wHour));
 
 			::FILETIME now_ft;
 			::GetSystemTimePreciseAsFileTime(&now_ft);
@@ -51,7 +51,7 @@ namespace lwlog::details::os
 			minute 	= static_cast<std::uint8_t>(details.tm_min);
 			second 	= static_cast<std::uint8_t>(details.tm_sec);
 
-			hour = datetime::handle_timezone<LocalTimePolicy>(details.tm_hour);
+			hour = datetime::handle_timezone<LocalTimePolicy>(static_cast<std::uint8_t>(details.tm_hour));
 
 			const auto nanoseconds_since_unix_epoch{ 
 				std::chrono::duration_cast<std::chrono::nanoseconds>(m_now.time_since_epoch()).count() };

diff --git a/lwlog/src/policy/log_policy_impl.h b/lwlog/src/policy/log_policy_impl.h
@@ -37,11 +37,8 @@ namespace lwlog
         backend.shutdown.store(false, std::memory_order_relaxed);
         backend.worker_thread = std::thread([&backend]() 
             {
-                while (true)
+                while (!backend.shutdown.load(std::memory_order_relaxed) || !backend.queue.is_empty())
                 {
-                    if (backend.shutdown.load(std::memory_order_relaxed) 
-                        && backend.queue.is_empty()) break;
-
                     if (!backend.queue.is_empty())
                     {
                         const auto& item{ backend.queue.dequeue() };