Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #303 : Added Payment Confirmation Modal #304

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

adarsh-jha-dev
Copy link
Contributor

Changes Made

In this pull request, I have addressed issue #303 by implementing a payment confirmation modal. The modal is displayed to users after they initiate a payment and provides clear feedback on the outcome of the transaction. The modal includes the following features:

  • A concise message indicating the result of the payment (success or failure).
  • Details of the transaction, including the amount, bank, and account number.
  • Action buttons for users to either close the modal or take additional actions.

Benefits

  • Fixes [Feature]: Add Payment Confirmation Modal #303
  • Improved user experience: Users now receive immediate feedback on the status of their payment, reducing uncertainty.
  • Increased user trust: Clear communication regarding the payment's outcome enhances user confidence in our application.

How to Test:

To test the payment confirmation modal, follow these steps:

  1. Open the application.
  2. Initiate a payment.
  3. Observe the payment confirmation modal, which will display the result of the transaction.
  4. Verify that the transaction details are accurately presented.
  5. Test the action buttons to ensure they function as expected.

This pull request aims to enhance the user experience and improve our application's trustworthiness by introducing the payment confirmation modal. It aligns with the objectives outlined in issue #303.

@adarsh-jha-dev
Copy link
Contributor Author

@phyleria , is there any update on this PR, i request you to please have a look at this suggestion and let me know if this is relevant

Copy link
Collaborator

@phyleria phyleria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adarsh-jha-dev please update this part to )} It currently throws an error.

@phyleria
Copy link
Collaborator

I get this whenever I try to pay out and the status never changes.
Screenshot from 2023-11-13 10-42-56

@adarsh-jha-dev
Copy link
Contributor Author

I get this whenever I try to pay out and the status never changes. Screenshot from 2023-11-13 10-42-56

are you still facing this?

@phyleria
Copy link
Collaborator

I get this whenever I try to pay out and the status never changes. Screenshot from 2023-11-13 10-42-56

are you still facing this?

Yes, I still am

Copy link
Collaborator

@phyleria phyleria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still the same unfortunately

@phyleria
Copy link
Collaborator

Can you show me what it shows on your end?

@adarsh-jha-dev
Copy link
Contributor Author

adarsh-jha-dev commented Nov 13, 2023

Could you please just check it one last time , I have planned it work somewhat like this :

  1. User initiates payment.
  2. "Please wait..." is displayed.
  3. After 2 seconds, the confirmation modal appears.
  4. After another 2 seconds, the modal closes, and "Payment Successful" is displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add Payment Confirmation Modal
2 participants