M2-4835: Linting rules for mindlogger-web-refactor

[sultanofcardio]

resolves: M2-4835

Objective

This PR creates a GitHub Action to run linting tasks on pull requests submitted to the repository. As part of the ticket, I took the opportunity to update the ESlint rules on the project to be more in line with those on mindlogger-admin. These updates have raised a number of linting issues, but won't block the merging of pull requests. While I've addressed some of the smaller items (and any error ones), I expect that these will be addressed in the normal course of feature development so that we can eventually require linting checks to pass in order to merge PRs.

Prettier Code Formatting

Prettier has been configured in the project as the code formatter of choice, but it is currently conflicting with a number of code formatting ESLint rules. The prettier ESLint plugin disables these rules if it is placed as an inherited configuration at the end of the extends array, so I have made this change. The prettier ESLint plugin also enables Prettier as an ESLint rule, so that code formatting issues become errors. This should be okay, since Prettier fixes them for you.

[farmerpaul]

I'm very happy with these changes, thanks @sultanofcardio. I just left one minor comment about max line length; hoping we can all align on having consistency here (at least between the FE apps, if not the BE).

[mbanting]

My review only focused on .eslintrc.js and .prettierrc.js files. Briefly looking at the rest of the changes they're a result of the changes to these aforementioned files. Thanks for putting this together and incorporating these updated rules.

Is it possible to hold off on merging until Wed Nov 21? We've been requested to code freeze the dev2.5 branch to accomodate it's release stabilization. I realize this delay will significantly increase the chance of code conflicts. Maybe this is the first PR that gets merged as soon as the code freeze is lifted.

[sultanofcardio]

Is it possible to hold off on merging until Wed Nov 21

Sure thing @mbanting. I held off ChildMindInstitute/mindlogger-admin#1472 for the same reason 👍

[mbanting]

Is it possible to hold off on merging until Wed Nov 21

Sure thing @mbanting. I held off ChildMindInstitute/mindlogger-admin#1472 for the same reason 👍

@sultanofcardio actually feel free to merge that one. We've only been ask to code freeze the dev2.5 branch for this repo, mindlogger-web-refactor. Thk you!

[moiskillnadne]

In my humble opinion, the semicolon in JS code makes it more overloaded for the eyes. Probably it is just my habit.

But to make the codebase consistent between repositories we should do it. It looks good to me.

Resolve conflicts please and merge it.