fix: Add timezone info to timestamp columns (M2-6932) #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sultanofcardio
force-pushed
the
feature/M2-6459-context-menu-date-tz
branch
from
25f3851
to
d5ffdf5
Compare
sultanofcardio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-6932
This PR adds time zone information to the various datetime fields in the database. I noticed this was missing while validating the implementation of M2 6459 in the admin preview environment.
I've accounted for the arbitrary server when handling the columns in the two answers tables (
answersandanswers_items).🪤 Peer Testing
Go to https://localhost:8000/docs#/Applets/applet_list_applets_get and try it out. The
createdAtandupdatedAtfields should include the timezone offset+00:00to indicate UTC✏️ Notes
There are some failing tests that need to be updated to account for these changes
I also explored a runtime version of this fix at feature/M2-6459-context-menu-date-tz-runtime with a smaller change set, but I thought this was the better approach