M2-7225: checkboxes & radio buttons new layout design #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 12, 2024 13:21
anq83
approved these changes
Jul 15, 2024
src/shared/ui/OptionCard.tsx
Outdated
|
|
||
| const CardWrapper = styled(YStack, { | ||
| minHeight: 188, | ||
|
|
src/shared/ui/OptionCard.tsx
Outdated
| type Props = { | ||
| imageUrl: string | null; | ||
| textColor?: string; | ||
|
|
src/shared/ui/ScrollableContent.tsx
Outdated
| @@ -122,7 +122,7 @@ const ScrollableContent: FC<Props> = ({ children, scrollEnabled }: Props) => { | |||
| showsHorizontalScrollIndicator={false} | |||
| showsVerticalScrollIndicator={false} | |||
| keyboardOpeningTime={0} | |||
| scrollEventThrottle={300} | |||
| scrollEventThrottle={100} | |||
There was a problem hiding this comment.
Is it ok to reduce this value in the shared component?
There was a problem hiding this comment.
Good call. I'll add it to Props
BamMironov
deleted the
feature/M2-7225-checkboxes-radio-new-layout-design
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Jira Ticket M2-7225
Changes include:
📸 Screenshots