-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [Duplicate Applet] Enhance Duplication (M2-7729) #1942
base: develop
Are you sure you want to change the base?
feat: [Duplicate Applet] Enhance Duplication (M2-7729) #1942
Conversation
This reverts commit aca7c8f.
This reverts commit 8ce387b.
The `useCheckReportServer` hook was previously accessing these from the URL, which restricted its use to pages that contain them. It's cleaner for the caller to get these props from the URL (if present) and pass them instead, so that the hook may enjoy wider use
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @sultanofcardio!
Did some brief peer testing for duplicating with and without report server configuration, and it worked as expected. Left just found one small suggestion.
I also created M2-8037 to add unit tests later and added TODOs referencing this followup ticket. I didn't see that this task was already captured as part of M2-8036. So that one was updated to just focus on unit tests for the other ticket, M2-7738.
Pre-approving now, and moving to Ready for QA since the suggested change won't impact functional testing.
import { InputController } from 'shared/components/FormComponents'; | ||
import { StyledErrorText, StyledModalWrapper, variables } from 'shared/styles'; | ||
import { CheckboxController, InputController } from 'shared/components/FormComponents'; | ||
import { StyledErrorText, StyledFlexColumn, StyledModalWrapper, variables } from 'shared/styles'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs StyledBodyLarge
for use below
import { StyledErrorText, StyledFlexColumn, StyledModalWrapper, variables } from 'shared/styles'; | |
import { | |
StyledBodyLarge, | |
StyledErrorText, | |
StyledFlexColumn, | |
StyledModalWrapper, | |
variables, | |
} from 'shared/styles'; |
<CheckboxController | ||
name={'includeReportServer'} | ||
control={control} | ||
label={t('duplicateAppletReportServer')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
label
prop is expecting an Element
label={t('duplicateAppletReportServer')} | |
label={<StyledBodyLarge>{t('duplicateAppletReportServer')}</StyledBodyLarge>} |
📝 Description
🔗 Jira Ticket M2-7729
This PR adds a checkbox to the applet duplication popups for including report server configuration. The checkbox is optional and duplication works the same without checking it.
When the checkbox is checked, the duplicated applet will contain these properties from the original applet:
reportServerIp
reportPublicKey
reportIncludeUserId
reportIncludeCaseId
reportEmailBody
Note
reportRecipients
is explicitly excluded📸 Screenshots
Screen.Recording.2024-10-11.at.11.41.48.AM.mov
🪤 Peer Testing
/verify
and/set-password
endpoints✏️ Notes
N/A