Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add By Participant view (M2-7798) #1938

Conversation

farmerpaul
Copy link
Contributor

@farmerpaul farmerpaul commented Oct 8, 2024

  • Tests for the changes have been added (in progress)
  • Delivered the fix or feature branches into develop or release branches via Squash and Merge (to keep clean history)

📝 Description

🔗 Jira Ticket M2-7798

Note

I've selected the Activity Status Tags branch (#1937) as the target branch for this PR, which it is dependent on. Please review this work as if that branch were already merged to develop. I'll rebase and re-target this branch accordingly after #1937 has been merged.

This PR adds the By Participant view to the PDP, including:

  • Support to call new API endpoint for By Participant view, /activities/applet/${appletId}/respondent/${subjectId}
  • Empty states for By Participant view (full account, limited account)
  • Adjustments to ActivityListItem component to support the new view

Also fixed some menu item logic to detect assignments correctly from the new view and handle disabled menu items properly for hidden activities/flows.

📸 Screenshots

Full Account/Team Member Empty State

CleanShot 2024-10-09 at 15 06 52@2x

Limited Account Empty State

CleanShot 2024-10-09 at 15 04 11@2x

List of Activities/Flows for which Participant is Respondent

CleanShot 2024-10-09 at 15 04 31@2x

🪤 Peer Testing

Tip

Ensure the enableActivityAssign feature flag is enabled in the environment you are testing from.

  1. For a given Participant, ensure you have activities or flows created with these characteristics:
    • One that is manually assigned to the Participant as the Respondent
    • One that is auto-assigned to the Participant as the Respondent
    • One that is not assigned to the Participant, but has submissions for them as the Respondent (e.g., via Take Now, or via a previous assignment that as since been removed)
    • One that is hidden
  2. From that Participant's PDP, ensure each of the activities/flows is listed in the By Participant view according to designs, taking into account the out-of-scope portions of the design as described in the AC of the ticket.
  3. Create a new Limited Account and a new Full Account, and ensure there are no activities/flows that are auto-assigned.
  4. Open the PDP > By Participant view for the Limited Account, and ensure the Limited Account empty state is shown.
  5. Open the PDP > By Participant view for the Full Account, and ensure the Full Account empty state is shown.

@farmerpaul farmerpaul changed the title feat: Add By Participant view (M2-7798, M2-7828) feat: Add By Participant view (M2-7798) Oct 8, 2024
@farmerpaul farmerpaul marked this pull request as ready for review October 9, 2024 18:14
@farmerpaul farmerpaul force-pushed the feature/M2-7825-activity-status-tags branch from 322646b to db11b5d Compare October 10, 2024 13:36
Add support to call new API endpoint for By Participant view,
`/activities/applet/${appletId}/respondent/${subjectId}`. Add empty
states to By Participant view and make adjustments to `ActivityListItem`
component to support the new view.

Fix some menu item logic to detect assignments correctly from the new
view and handle disabled menu items properly for hidden
activities/flows.
@farmerpaul farmerpaul force-pushed the feature/M2-7798-revised-PDP-by-participant branch from 3088de6 to a1656b1 Compare October 10, 2024 13:40
@farmerpaul
Copy link
Contributor Author

Closing in favour of #1941.

@farmerpaul farmerpaul closed this Oct 11, 2024
@farmerpaul farmerpaul added duplicate This issue or pull request already exists Do not review labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not review duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant