Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optional text formatting optimizations (M2-7412) #1922

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

AlejandroCoronadoN
Copy link
Contributor

@AlejandroCoronadoN AlejandroCoronadoN commented Sep 13, 2024

📝 Description

Modified text formatting in the UI element that’s used when the subscales configurator is enabled. The size of the tooltip and the font size was modified to better fit the content of Optional Text from the Subscale generator.

🔗 Jira Ticket M2-7412

Changes include:

  • [Reduce the font size of the text]
  • [Ensure the text aligns with the margins, possibly meaning it should fully utilize the space within the hover window's boundaries]
  • [Adjust the text so that words do not break mid-word when wrapping to the next line]
  • [Increase the width of the hover window: Assess if expanding the width of the hover window is necessary to better accommodate the text]

📸 Screenshots

Screenshot 2024-09-13 at 9 51 17 a m

🪤 Peer Testing

  1. Create an activity
  2. Create one or more Items inside the activity using the subscale feature. When selecting csv file (lookuptable), be sure to include optional text in the last colum and try to add a long parragraph to test the formatting.
    3.Remember to enable scores inside the item and to create an score inside the configuration menu.
  3. Link items to the scores and subscales
  4. Assign this activity to any user.
  5. As a user complete the assigned activity. Your answers must match the lookuptable values in order to display the correct output on the FE.
  6. Go back to the admin app and select the user who filled your activity.
  7. Select the activity for this user and open the charts and insights panel.
  8. Go to the chart and hover over the new data-point.
  9. Optional text should be displayed here.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1922.d19gtpld8yi51u.amplifyapp.com

Copy link
Contributor

@sultanofcardio sultanofcardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation of the feature seems good, but I left you some feedback on the tests

…ByTestId. Changed padding on parragraph to align with tooltip title
Copy link
Contributor

@sultanofcardio sultanofcardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving

@farmerpaul farmerpaul merged commit a1654a9 into develop Sep 25, 2024
5 checks passed
@farmerpaul farmerpaul deleted the fix/M2-7412-OptionalText-Formatting-Optimizations branch September 25, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants