feat: list only assigned activities on PDP (M2-7475) #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the `Participant/Activities` screen to only show activities for which the participant has assignments either as the respondent or the target subject. Update tests to reflect this change. Also move definition of `mockedOwnerSubject` to the shared `mock.ts` file, and align the subject details in the `preloadedState` with that subject. This required making small tweaks to two tests.
|
Hey @qiushihe, I needed to re-create this PR since Amplify failed to deploy the first time, and we're starting to try out this new workflow whereby QA tests in the Amplify preview environment before merging to |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
sultanofcardio
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixorfeaturebranches intodeveloporreleasebranches viaSquash and Merge(to keep clean history)📝 Description
🔗 Jira Ticket M2-7475
This PR does a first-pass of incorporating MI Assign into the Participant Details Page (PDP). It calls the newly introduced endpoint,
/activities/applet/{applet_id}/subject/{subject_id}, to restrict that page to only those activities/flows that are assigned to the current participant, either as the respondent or the target subject.Also updated tests to reflect this change. In doing so, moved definition of
mockedOwnerSubjectto the sharedmock.tsfile, and aligned the subject details in thepreloadedStatewith that subject. This required making small tweaks to two tests.📸 Screenshots
N/A
🪤 Peer Testing
Note
This feature depends on the
enableActivityAssignfeature flag. This should already be enabled in dev/local environments. It would also be worth testing this with that feature flag disabled to confirm that previous behaviour (listing all activities & flows regardless of assignments) is preserved with the MI Assign feature disabled, by addingfeatures.enableActivityAssign = falseprior to thereturnstatement here inuseFeatureFlags.Refer to AC of ticket in Jira.