Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update copy in MI Assign help dialogue (M2-7317) #1916

Merged

Conversation

AlejandroCoronadoN
Copy link
Contributor

@AlejandroCoronadoN AlejandroCoronadoN commented Sep 6, 2024

📝 Description

🔗 Jira Ticket M2-7317

As an admin, I want to see help text when I click the :question_mark: button so that I can easily understand the functionality and purpose of Assign.

  • Replaced english and french version of HelpContent for activities help popup.
  • Reused styled components for titles and parragraphs using Trans.
  • Replaced French Version

📸 Screenshots

image

🪤 Peer Testing

  • Log into the admin app.
  • Create an activity.
  • Go to the Activities tab
  • Inside activities, you created activity should be dispalyed.
  • Click on "Assign" button on the rightside
    -Click on the :question_mark: button to display the content

✏️ Notes

  • The content in the Sigma file is different from the content on the Jira Ticket. I used Jira information since it looked more complete.
  • Not sure if I should add hyperlinks from Jira.

Replaced english and french version of HelpContent for activities help
popup.
Added styles for titles and parragraphs.
@AlejandroCoronadoN AlejandroCoronadoN changed the title fix:[M2-7371]-Chaged-Activity-Assignment-Help-Menu-Content fix:[M2-7317]-Chaged-Activity-Assignment-Help-Menu-Content Sep 6, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1916.d19gtpld8yi51u.amplifyapp.com

@farmerpaul
Copy link
Contributor

farmerpaul commented Sep 11, 2024

Hi @AlejandroCoronadoN, just another reminder about PR best practices:

  1. Avoid deleting this line from the PR description template to support automation and add 1-click access to the Jira ticket:

    🔗 [Jira Ticket M2-7317](https://mindlogger.atlassian.net/browse/M2-7317)
    
  2. Use the PR format as specified in our shared PR authoring guidelines:

    type(optional scope): brief summary (M2-####[, additional tickets])

    So in this case, I'd recommend:

    fix: update copy in MI Assign help dialogue (M2-7317)
    

Thanks!

@farmerpaul farmerpaul self-requested a review September 11, 2024 14:39
@AlejandroCoronadoN
Copy link
Contributor Author

@farmerpaul I made the changes, thanks for the comments, I think I copied this format from an old Backend PR but you are right. I'll be using this title format from now on. Also, I will add the Jira link and tag from now on.

@farmerpaul farmerpaul changed the title fix:[M2-7317]-Chaged-Activity-Assignment-Help-Menu-Content fix: update copy in MI Assign help dialogue (M2-7317) Sep 12, 2024
Copy link
Contributor

@farmerpaul farmerpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @AlejandroCoronadoN! Approving.

Even though you mentioned that you fix the PR title, for some reason it was still showing the old version… 🤔

So I hope you don't mind, I just went ahead and updated it to the suggested one fix: update copy in MI Assign help dialogue (M2-7317).

Also, just a reminder to follow the new QA workflow for the admin & web app: Do not merge this yet. Instead, set the Jira task's status to "TO BE TESTED" (or move the task to the "FQA - READY" column). Katty will assign it to herself, and then test your work in the PR's Amplify preview env, and once she sets the status to "READY TO MERGE", you can merge it! 🚀

@mbanting
Copy link
Contributor

@AlejandroCoronadoN as mentioned above, with these two approvals please return back to the JIRA ticket and mark as To Be Tested so that @kattyode knows to begin QAing this in this PR's feature environment.

@AlejandroCoronadoN AlejandroCoronadoN merged commit 815b45f into develop Sep 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants