M2-4969: [Admin Panel] Set up Banners infra for system messages #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
alex-i-e
reviewed
Feb 5, 2024
alex-i-e
reviewed
Feb 5, 2024
farmerpaul
force-pushed
the
feature/M2-4969-set-up-banners-infra-for-system-messages
branch
from
664b205
to
2f91296
Compare
farmerpaul
force-pushed
the
feature/M2-4969-set-up-banners-infra-for-system-messages
branch
from
2f91296
to
3c20a59
Compare
IhorNesterenko99
approved these changes
Feb 6, 2024
alex-i-e
approved these changes
Feb 6, 2024
Currently the app only shows a single static banner below the breadcrumbs. This slice will support being able to display other banners in place of popups.
Used the MUI Alert component, which already closely aligns with Figma designs. Added MUI Snackbar-like a11y behaviour to prevent alerts from auto-closing while hovering or if window missing focus. Set up default styling via MUI theme settings. Added missing sprites for success/error states.
Now it uses the new Banner base component. Also add it to the list of banner components available to enable in the banners state schema, and renamed BannerSchema to BannersSchema.
Renders banners dictated by banners Redux state. Includes automatic collapse animation via Material UI TransitionGroup.
Adds default app version warning banner on sign-in and clears banners on sign-out.
Implement custom version instead.
farmerpaul
force-pushed
the
feature/M2-4969-set-up-banners-infra-for-system-messages
branch
from
3a30add
to
b92ef06
Compare
farmerpaul
deleted the
feature/M2-4969-set-up-banners-infra-for-system-messages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: M2-4969 (parent story: M2-4823)
Objective
This PR adds infrastructure for system messages as banners, which will be used in place of specific popups (as assessed in popup audit), including:
Also in this PR, only these system messages have been converted to use the new infra to keep this PR from getting too large (see Follow-up tasks below):
VersionWarningBanner(formerly
Banner)AppletWithoutChangesBanner(formerly
AppletWithoutChangesPopup)Notes
Commits have been broken down into logical changesets, each with an explanation of changes, to make this PR easier to review. So please review commit-by-commit. 🙏🏻
Screenshots
demo.mov
Follow-up tasks