Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try setting specific output directory for static libs #456

Closed
wants to merge 2 commits into from

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Oct 30, 2024

No description provided.

Copy link

coveralls-official bot commented Oct 30, 2024

Pull Request Test Coverage Report for Build 11601232166

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.028%

Totals Coverage Status
Change from base Build 11599391321: 0.0%
Covered Lines: 3497
Relevant Lines: 4425

💛 - Coveralls

@emlowe
Copy link
Contributor Author

emlowe commented Oct 30, 2024

@AmineKhaldi Do you see a downside to this - it makes building the rust bindings simpler since all the libs will be in a single directory on all the platforms (I think anyway)

@emlowe emlowe requested a review from Rigidity October 30, 2024 21:09
@emlowe emlowe marked this pull request as ready for review October 30, 2024 21:09
@AmineKhaldi
Copy link
Contributor

@AmineKhaldi Do you see a downside to this - it makes building the rust bindings simpler since all the libs will be in a single directory on all the platforms (I think anyway)

Hmm this doesn't make sense to me, AFAIK genex do not expand at that time, and they're mainly meant to be used with targets, so if this is working like this, it seems unintended.

Another point to consider is that by setting this here, it will apply to everything below it. I've sent an experiment that targets specifically what we need, please let me know if it works: #458

@emlowe emlowe closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants