Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track weight proof tasks #18896

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Track weight proof tasks #18896

wants to merge 2 commits into from
+12 −9

Conversation

almogdepaz
Copy link
Contributor

Purpose:

track weight proof segment creation tasks until closed

Current Behavior:

we cancel tasks and stop tracking them

New Behavior:

keep a list of all tasks and remove when they are done

Testing Notes:

@almogdepaz almogdepaz added full_node sync Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog labels Nov 19, 2024
@almogdepaz almogdepaz marked this pull request as ready for review November 20, 2024 16:07
@almogdepaz almogdepaz requested a review from a team as a code owner November 20, 2024 16:07
arvidn
arvidn reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you also need to await any remaining tasks on shutdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvidn arvidn arvidn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog full_node sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@almogdepaz @arvidn