Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): refactor the select input #72

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix(select): refactor the select input #72

merged 1 commit into from
Dec 20, 2024

Conversation

Sukaato
Copy link
Member

@Sukaato Sukaato commented Dec 18, 2024

fixes: #63


What is the current behavior?

on frmakework, outside stencil, the select popover does not showed up

What is the new behavior?

  • select popover display rework to avoid framework delegate

Does this introduce a breaking change?

  • Yes
  • No

Other information

@Sukaato Sukaato requested a review from Xenxia December 18, 2024 23:23
@github-actions github-actions bot added bug Something isn't working dependencies Pull requests that update a dependency file package: vue @poppy-ui/vue package related package: core @poppy-ui/core package related labels Dec 18, 2024
@Sukaato Sukaato force-pushed the fix/63-fix-select branch 3 times, most recently from 7cf3242 to 5a73f12 Compare December 18, 2024 23:35
@Sukaato Sukaato force-pushed the fix/63-fix-select branch 2 times, most recently from 148ef46 to ddacc5a Compare December 20, 2024 12:15
- select popover display rework to avoid framework delegate

fixes: #63
@Sukaato Sukaato merged commit 014b506 into main Dec 20, 2024
16 checks passed
@Sukaato Sukaato deleted the fix/63-fix-select branch December 20, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file package: core @poppy-ui/core package related package: vue @poppy-ui/vue package related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug (vue): pop-select-option is not loaded
2 participants