fix(input): display error text #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new behavior: - display helper text by default - display error text if present - hide helper text if error text is present - add text ellipsis on input fixes: #67
github-actions
bot
added
bug
Xenxia
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #67
What is the current behavior?
The error text is shown only if the input has
:user-invalid, which means it have to be validated by constrain that can not be controlled for the momentWhat is the new behavior?
Does this introduce a breaking change?
probably, but poppy-ui still in dev
Other information
This changes will affect all input that have helper text and error text properties
I also fix the ghost variant of the input, which is now transparent by default, and opaque when focused