Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Popen communicate instead of wait #25

Closed
wants to merge 2 commits into from
Closed

use Popen communicate instead of wait #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8fa8ed
use Popen communicate instead of wait
schmidax Mar 6, 2024
89ed431
update returncode check of check_mk_agent
schmidax Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/checkmk_kube_agent/send_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,14 +373,14 @@ def machine_sections_worker(
["/usr/local/bin/check_mk_agent"],
stdout=subprocess.PIPE,
) as process:
returncode = process.wait(5)
if returncode != 0:
(out, err) = process.communicate(timeout=5)
if process.returncode != 0:
# we don't capture stderr so it's printed to stderr of this process
# and hopefully contains a helpful error message...
raise RuntimeError("Agent execution failed.")
if process.stdout is None:
raise RuntimeError("Could not read agent output")
sections = process.stdout.read().decode("utf-8")
sections = out.decode("utf-8")

logger.info("Parsing and sending machine sections")
cluster_collector_response = session.post(
Expand Down
Loading