Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.4.0 #576

Merged
merged 127 commits into from
Apr 17, 2024
Merged

Release 4.4.0 #576

merged 127 commits into from
Apr 17, 2024

Conversation

robin-checkmk
Copy link
Member

@robin-checkmk robin-checkmk commented Mar 11, 2024 •
edited
Loading

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: e.g. #1

What is the new behavior?

Other information

@robin-checkmk robin-checkmk linked an issue Apr 5, 2024 that may be closed by this pull request
[BUG] module "folder" not idempotent #584
Closed
@lgetwan
Copy link
Contributor

lgetwan commented Apr 9, 2024

I didn't have the chance yet to check out why the bakery module fails.
I started a review to Michael's Cluster extension and added 2 recommendations for simpler code. Let's see how Michael thinks about that.
The rest looks fine to me!

@lgetwan
Copy link
Contributor

lgetwan commented Apr 10, 2024

The cluster extension PR is now ready for merging.
I also fixed the Bakery integration test in #588, but the sanity checks are not completely happy, there.

@robin-checkmk
Copy link
Member Author

robin-checkmk commented Apr 15, 2024 •
edited
Loading

Found the issue with the sanity checks, the Ansible project branched ind preparation of the 2.17. release and now Ansible devel is 2.18. I added the corresponding ignores and tests should be back to good now.

@robin-checkmk
Merge pull request #585 from msekania/feature/add_cluster_managment_t…
6136295 
…o_host_module

Feature/add cluster managment to host module
@robin-checkmk robin-checkmk marked this pull request as ready for review April 15, 2024 21:01
lgetwan
lgetwan approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@lgetwan lgetwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@robin-checkmk robin-checkmk merged commit 09af4e5 into main Apr 17, 2024
228 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgetwan lgetwan lgetwan approved these changes

@Max-checkmk Max-checkmk Awaiting requested review from Max-checkmk Max-checkmk is a code owner

Assignees

@robin-checkmk robin-checkmk

Labels
documentation Improvements or additions to documentation module:bakery This affects the bakery module module:folder This affects the folder module module:host This affects the host module release:4.4.0 Affects the mentioned release. role:agent This affects the agent role role:server This affects the server role
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] module "folder" not idempotent
5 participants
@robin-checkmk @lgetwan @msekania @kirby0025 @thorian93