VSCode | Fix UI Freezing and Unclickable Icons (AST-70028) #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues
Fixed Issues
|
src/cx/cx.ts
Outdated
| @@ -253,7 +253,9 @@ export class Cx implements CxPlatform { | |||
| try { | |||
| enabled = await cx.ideScansEnabled(); | |||
| } catch (error) { | |||
| logs.error(error); | |||
| const errMsg = `Error checking tenant configuration: ${error}`; | |||
| vscode.window.showErrorMessage("Provided Checkmarx One API KEY is invalid"); | |||
There was a problem hiding this comment.
couldn't it be that we get another issue? (it can be even network issue...)
There was a problem hiding this comment.
Yes, I need to talk about it with Daniel
There was a problem hiding this comment.
do we have an error code the indicate the reason for the error?
if yes we can use it
src/cx/cx.ts
Outdated
| return false; | ||
| } | ||
| } catch (error) { | ||
| logs.error(`${invalidAPIKeyMsg}: ${error}`); |
There was a problem hiding this comment.
if we got exit code != 0, it means that apikey is invalid
but if we catch an exception it means other issue happened, could be not related to apikey itself
no?
src/cx/cx.ts
Outdated
| } | ||
| } catch (error) { | ||
| logs.error(`${invalidAPIKeyMsg}: ${error}`); | ||
| vscode.window.showErrorMessage(invalidAPIKeyMsg); |
AlvoBen
changed the title
miryamfoiferCX
previously approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
References
Testing
Checklist