Other/fix secret detection label with path and line(AST-69045) (#972)

* update-js wrapper version * update in package.json * Fix gaps in scs feture
Checkmarx · Oct 9, 2024 · e1256c8 · e1256c8
1 parent 3ffe302
commit e1256c8
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 7 deletions.
diff --git a/src/models/results.ts b/src/models/results.ts
@@ -79,8 +79,6 @@ export class AstResult extends CxResult {
     this.scaType = result.scaType;
     this.label = result.data.queryName
       ? result.data.queryName
-      : result.data.ruleName
-      ? result.data.ruleName
       : this.formatFilenameLine(result)
       ? this.formatFilenameLine(result)
       : result.id
@@ -112,12 +110,13 @@ export class AstResult extends CxResult {
   }
 
   formatFilenameLine(result: {
-    data?: { line?: number; filename?: string };
+    data?: { line?: number; filename?: string; ruleName?: string };
   }): string {
     const filename = result.data?.filename?.split("/").pop();
     const line = result.data?.line;
-    if (filename && line !== undefined) {
-      return `(/${filename}:${line})`;
+    const ruleName = result.data?.ruleName;
+    if (ruleName && filename && line !== undefined) {
+      return `${ruleName} (/${filename}:${line})`;
     }
   }
 

diff --git a/src/utils/interface/details.ts b/src/utils/interface/details.ts
@@ -107,6 +107,14 @@ export class Details {
 			</body>`;
   }
 
+  secretDetectiongeneralTab() {
+    return `<body>
+				<span>
+					${this.result.description ? "<p>" + this.result.description + "</p>" : ""}
+				</span>
+				</body>`;
+  }
+
   scaView(
     severityPath,
     scaAtackVector,
@@ -177,7 +185,7 @@ export class Details {
 
     return `
 	  <div>
-		${remediation ? `<p>${remediation}</p>` : ""}
+		${remediation ? `<p>${remediation}.</p>` : ""}
 	  </div>
 	`;
   }

diff --git a/src/views/resultsView/astDetailsView.ts b/src/views/resultsView/astDetailsView.ts
@@ -334,7 +334,7 @@ export class AstDetailsDetached implements vscode.WebviewViewProvider {
                 )
               : this.result.type === constants.scsSecretDetection
               ? html.tab(
-                  html.generalTab(cxPath),
+                  html.secretDetectiongeneralTab(),
                   html.secretDetectionDetailsDescriptionTab(),
                   html.secretDetectionDetailsRemediationTab(),
                   messages.generalTab,