Change IsAllowedEngine func to return true when packageEnforcementEnabled is false (AST-76112) #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bled is set to false because that means that user has license for everything
AlvoBen
changed the title
|
No New Or Fixed Issues Found |
AlvoBen
changed the title
internal/services/asca_test.go
Outdated
| @@ -130,3 +131,20 @@ func TestCreateASCAScanRequest_EngineRunningAndDefaultAgentAndNoLicense_Success( | |||
| assert.Nil(t, wrapperParams.ASCAWrapper.HealthCheck()) | |||
| _ = wrapperParams.ASCAWrapper.ShutDown() | |||
| } | |||
|
|
|||
| func TestCreateASCAScanRequest_CheckLicenseWhenPackageEnforcementFFOff_SuccessWithNilError(t *testing.T) { | |||
There was a problem hiding this comment.
rename to use the key words when, should
There was a problem hiding this comment.
But this test name is obvious and according to our conventions
There was a problem hiding this comment.
should be something like:
TestCreateASCAScanRequest_whenCheckLicenseWithPackageEnforcementFFOff_shouldSuccess
elchananarb
reviewed
Dec 3, 2024
There was a problem hiding this comment.
maybe return
if !flagResponse.Status {
return true, nil
}
jwtStruct, err := getJwtStruct()...
Early return if the feature flag is disabled, to avoid unnecessary nested logic
miryamfoiferCX
previously approved these changes
Dec 3, 2024
|
Test are not passing because stability issue in IAC-Security engine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
References
Testing
Checklist