Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Code Repository Flag & Support PR Decoration For GH/GL On-prem (AST-72979, AST-72975) #921

Merged

Conversation

miryamfoiferCX
Copy link
Contributor

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

  1. add code-repository-url optional flag
  2. support PR decoration command for github & gitlab on-prem

References

Include supporting link to GitHub Issue/PR number

Testing

unit test for the new optional flag

manually E2E tests on on-prem machines

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

2. support PR decoration command for github & gitlab on-prem
@OrShamirCM OrShamirCM requested a review from a team October 30, 2024 10:56
@miryamfoiferCX miryamfoiferCX marked this pull request as ready for review October 31, 2024 13:13
Dockerfile Show resolved Hide resolved
internal/params/flags.go Outdated Show resolved Hide resolved
OrShamirCM
OrShamirCM previously approved these changes Nov 4, 2024
OrShamirCM
OrShamirCM previously approved these changes Nov 4, 2024
@miryamfoiferCX miryamfoiferCX merged commit a211319 into main Nov 5, 2024
8 checks passed
@miryamfoiferCX miryamfoiferCX deleted the feature/MiryamFoifer/support-github-gitlab-on-prem branch November 5, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants