Fix triggering scan without engines flags does not trigger secret detection by default (AST-69529) #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LeonardoLordelloFontes
commented
Oct 11, 2024
LeonardoLordelloFontes
commented
- Fixed triggering scan without engines flags does not trigger secret detection by default
- Fixed edge case where the SCS scan would start without any micro engine (when it shouldn't start at all)
- Updated unit tests and integration tests accordingly
…ags-does-not-trigger-Secret-Detection-by-default
LeonardoLordelloFontes
requested review from
OrShamirCM and
AlvoBen
as code owners
|
Policy Management Violations
No New Or Fixed Issues Found |
arturfalcao
approved these changes
Oct 11, 2024
AlvoBen
approved these changes
Oct 14, 2024
LeonardoLordelloFontes
deleted the
bug/Triggering-scan-without-Engines-flags-does-not-trigger-Secret-Detection-by-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.