Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix triggering scan without engines flags does not trigger secret detection by default (AST-69529) #905

Conversation

LeonardoLordelloFontes
Copy link
Collaborator

@LeonardoLordelloFontes LeonardoLordelloFontes commented Oct 8, 2024

  • Fixed triggering scan without engines flags does not trigger secret detection by default
  • Fixed edge case where the SCS scan would start without any micro engine (when it shouldn't start at all)
  • Updated unit tests and integration tests accordingly

@OrShamirCM OrShamirCM requested a review from a team October 8, 2024 16:16
Copy link

github-actions bot commented Oct 8, 2024

Logo
Checkmarx One – Scan Summary & Detailsf12d99bc-76db-4abb-9cd4-d961104ae43c

Policy Management Violations

Policy Name Rule(s) Break Build
[SAST-ML0] Not allowed NEW Sast vulnerabilities true

No New Or Fixed Issues Found

@LeonardoLordelloFontes LeonardoLordelloFontes marked this pull request as ready for review October 11, 2024 08:57
@LeonardoLordelloFontes LeonardoLordelloFontes deleted the AST-69529-Triggering-scan-without-Engines-flags-does-not-trigger-Secret-Detection-by-default branch October 11, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant