Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print policy violations only if any rule was violated (AST-66024) #879

Merged
merged 13 commits into from
Sep 22, 2024

Conversation

sarahCx
Copy link
Contributor

@sarahCx sarahCx commented Sep 18, 2024

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Check if there was no role that was violated in the policy, the policy will not be displayed in the PR decoration and in console summary.

References

https://checkmarx.atlassian.net/browse/AST-66024

Testing

To console summery: the test verifies that when there are no policy violations, the message "policy management violation" will not be printed.
To PR Decoration: the test verifies that when there are no policy violations, the policy will not be send to github.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@OrShamirCM OrShamirCM requested a review from a team September 18, 2024 11:07
Copy link

github-actions bot commented Sep 18, 2024

Logo
Checkmarx One – Scan Summary & Detailsb6e18010-9c5d-4e9a-9d87-a35be54bce4a

Policy Management Violations

Policy Name Rule(s) Break Build
[SAST-ML0] Not allowed NEW Sast vulnerabilities true

Fixed Issues

Severity Issue Source File / Package
MEDIUM CVE-2023-49559 Go-github.com/vektah/gqlparser/v2-v2.4.5

internal/commands/result.go Outdated Show resolved Hide resolved
internal/commands/result.go Outdated Show resolved Hide resolved
internal/commands/result.go Show resolved Hide resolved
internal/commands/result.go Show resolved Hide resolved
@AlvoBen AlvoBen merged commit 85fe624 into main Sep 22, 2024
9 checks passed
@AlvoBen AlvoBen deleted the feature/PRDecorationRulesViolated branch September 22, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants