Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI | Support download and execute of Vorpal engine in Linux arm64 (AST-63697) #854

Merged
merged 7 commits into from
Sep 1, 2024
Merged

CLI | Support download and execute of Vorpal engine in Linux arm64 (AST-63697) #854

merged 7 commits into from
Sep 1, 2024

Conversation

AlvoBen
Copy link
Collaborator

@AlvoBen AlvoBen commented Sep 1, 2024 •
edited
Loading

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Added support to download and execute vorpal engine for Linux arm64.

References

https://checkmarx.atlassian.net/browse/AST-63697

Testing

X

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@github-actions github-actions bot added bug Something isn't working fix labels Sep 1, 2024
@OrShamirCM OrShamirCM requested a review from a team September 1, 2024 06:32
@AlvoBen AlvoBen changed the title fix/benalvo/vorpal-for-arm CLI | Support download and execute of Vorpal engine in Linux arm64 (AST-63697) Sep 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – d8e41cff-cfa2-4500-9dce-c7b1c86a0d42

Policy Management Violations

Policy Name Rule(s) Break Build
[SAST-ML0] Not allowed NEW Sast vulnerabilities true

No New Or Fixed Issues Found

OrShamirCM
OrShamirCM approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@OrShamirCM OrShamirCM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, there are no tests per OS?

@AlvoBen AlvoBen merged commit 4bdd1e1 into main Sep 1, 2024
11 checks passed
@AlvoBen AlvoBen deleted the fix/benalvo/vorpal-for-arm branch September 1, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrShamirCM OrShamirCM OrShamirCM approved these changes

Assignees
No one assigned
Labels
bug Something isn't working fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlvoBen @OrShamirCM @BenAlvo1