Support scs engine In scan create Resubmit command (AST-63906) #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Policy Management Violations
No New Or Fixed Issues Found |
…Checkmarx/ast-cli into Itay/support-SCS-in-scan-create
AlvoBen
reviewed
Aug 20, 2024
internal/commands/scan.go
Outdated
| SCSMapConfig := make(map[string]interface{}) | ||
| SCSConfig := wrappers.SCSConfig{} | ||
| SCSMapConfig[resultsMapType] = commonParams.MicroEnginesType // scs is still microengines in the scans API | ||
| userScanTypes, _ := cmd.Flags().GetString(commonParams.ScanTypes) | ||
| SCSRepoToken, _ := cmd.Flags().GetString(commonParams.SCSRepoTokenFlag) | ||
| SCSRepoURL, _ := cmd.Flags().GetString(commonParams.SCSRepoURLFlag) | ||
| SCSEngines, _ := cmd.Flags().GetString(commonParams.SCSEnginesFlag) | ||
| if resubmitConfig != nil { | ||
| for _, config := range resubmitConfig { |
There was a problem hiding this comment.
Extract this scope to a new method - createSCSResubmitConfig(...).
This will make the function more readable and will answer the Single Responsibility Principle.
Also, it will probably fix your lint error
internal/commands/scan_test.go
Outdated
| result, _ := addSCSScan(cmdCommand, resubmitConfig) | ||
|
|
||
| expectedConfig := wrappers.SCSConfig{ | ||
| Twoms: "true", |
internal/commands/scan_test.go
Outdated
| { | ||
| Type: commonParams.ScsType, | ||
| Value: map[string]interface{}{ | ||
| configTwoms: "true", |
internal/commands/scan_test.go
Outdated
| { | ||
| Type: commonParams.ScsType, | ||
| Value: map[string]interface{}{ | ||
| configTwoms: "true", |
|
Great job! |
AlvoBen
approved these changes
Aug 20, 2024
Korjen97
changed the title
Korjen97
changed the title
OrShamirCM
reviewed
Aug 26, 2024
| if resubmitConfig != nil { | ||
| scsConfig = createResubmitConfig(resubmitConfig, scsRepoToken, scsRepoURL) | ||
| SCSMapConfig[resultsMapValue] = &scsConfig | ||
| return SCSMapConfig, nil |
There was a problem hiding this comment.
dont you need the config builder to finish his work first?
OrShamirCM
reviewed
Aug 26, 2024
| func createResubmitConfig(resubmitConfig []wrappers.Config, scsRepoToken, scsRepoURL string) wrappers.SCSConfig { | ||
| scsConfig := wrappers.SCSConfig{} | ||
| for _, config := range resubmitConfig { | ||
| resubmitTwoms := config.Value[configTwoms] |
There was a problem hiding this comment.
what is the difference between the regular config building and resubmit? Can't we re-use the regular build config?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
References
Testing
Checklist