Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the description result incorrectly if the vulnerability contains quotation (AST-40454) #833

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

elchananarb
Copy link
Contributor

@elchananarb elchananarb commented Aug 13, 2024

Description

Eclipse & visual studio extension, display description incorrectly if vulnerability has ""

References

https://checkmarx.atlassian.net/browse/AST-40454

Testing

Describe how this change was tested. Be specific about anything not tested and reasons why. If this solution has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@github-actions github-actions bot added the bug Something isn't working label Aug 13, 2024
@OrShamirCM OrShamirCM requested a review from a team August 13, 2024 12:12
Copy link

github-actions bot commented Aug 13, 2024

Logo
Checkmarx One – Scan Summary & Details62964ba8-c925-40e7-ab38-cb4f100eb701

Policy Management Violations

Policy Name Rule(s) Break Build
[SAST-ML0] Not allowed NEW Sast vulnerabilities true

No New Or Fixed Issues Found

@elchananarb elchananarb changed the title display description incorrectly if vulnerability has quotes display description incorrectly if vulnerability has quotes (AST-40454) Aug 13, 2024
OrShamirCM
OrShamirCM previously approved these changes Aug 14, 2024
@OrShamirCM OrShamirCM dismissed their stale review August 14, 2024 06:39

Need to add test

@elchananarb elchananarb changed the title display description incorrectly if vulnerability has quotes (AST-40454) Display the description result incorrectly if the vulnerability contains quotation (AST-40454) Aug 14, 2024
@elchananarb elchananarb merged commit 3f771a5 into main Aug 15, 2024
9 checks passed
@elchananarb elchananarb deleted the bug/elchanan/display-description-incorrectly branch August 15, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants