Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI | Handle Export Service Bad Request (AST-42958, AST-64307) #832

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

AlvoBen
Copy link
Collaborator

@AlvoBen AlvoBen commented Aug 13, 2024

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

In some tenants we are getting bad request response when calling to export service initiating export report. This is caused of calling the export service to fast when the sca scan runner is still terminating. I added retry mechanism to handle this flow.

References

https://checkmarx.atlassian.net/browse/AST-42958
https://checkmarx.atlassian.net/browse/AST-64307

Testing

Added integration test that re-create this problem

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@OrShamirCM OrShamirCM requested a review from a team August 13, 2024 06:21
@github-actions github-actions bot added bug Something isn't working fix labels Aug 13, 2024
@AlvoBen AlvoBen changed the title handle export bad request CLI | Handle Export Service Bad Request (AST-42958) Aug 13, 2024
Copy link

github-actions bot commented Aug 13, 2024

Logo
Checkmarx One – Scan Summary & Detailsdf89a331-50b0-44fc-964f-a02dbea0dc80

Policy Management Violations

Policy Name Rule(s) Break Build
[SAST-ML0] Not allowed NEW Sast vulnerabilities true

No New Or Fixed Issues Found

@AlvoBen AlvoBen changed the title CLI | Handle Export Service Bad Request (AST-42958) CLI | Handle Export Service Bad Request (AST-42958, AST-64307) Aug 13, 2024
@AlvoBen AlvoBen merged commit f74e87f into main Aug 13, 2024
9 checks passed
@AlvoBen AlvoBen deleted the fix/benalvo/handle-export-bad-request branch August 13, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants