Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "About this vulnerability" link (AST-35994) #682

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Fix "About this vulnerability" link (AST-35994) #682

merged 6 commits into from
Mar 27, 2024

Conversation

elchananarb
Copy link
Contributor

@elchananarb elchananarb commented Mar 19, 2024 •
edited
Loading

Description

This PR fixes the incorrect "About this vulnerability" link (AST-35994) to direct users to the correct vulnerability information

References

https://checkmarx.atlassian.net/browse/AST-35994

Testing

Add unit test to check the creation of the correct vulnerability fix link

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@elchananarb
Fix "About this vulnerability" link
7d6075d 
Fix "About this vulnerability" link
@pedrompflopes pedrompflopes requested review from a team and pedrompflopes and removed request for a team March 19, 2024 08:34
@github-actions github-actions bot added the bug Something isn't working label Mar 19, 2024
@pedrompflopes pedrompflopes requested a review from tiagobcx March 19, 2024 08:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 6137e892-bddc-4f66-99d2-2fe028f670e2

Policy Management Violations

Policy Name Rule(s) Break Build
[SAST-ML0] Not allowed NEW Sast vulnerabilities true

No New Or Fixed Issues Found

@elchananarb elchananarb merged commit d153d73 into main Mar 27, 2024
8 checks passed
@elchananarb elchananarb deleted the bug/elchanan/up-fixlink branch March 27, 2024 12:39
@elchananarb elchananarb restored the bug/elchanan/up-fixlink branch April 1, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@checkmarx-kobi-hagmi checkmarx-kobi-hagmi checkmarx-kobi-hagmi approved these changes

@OrShamirCM OrShamirCM OrShamirCM approved these changes

@pedrompflopes pedrompflopes Awaiting requested review from pedrompflopes pedrompflopes was automatically assigned from Checkmarx/ast-galactica-team

@tiagobcx tiagobcx Awaiting requested review from tiagobcx tiagobcx was automatically assigned from Checkmarx/ast-galactica-team

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elchananarb @OrShamirCM @checkmarx-kobi-hagmi