Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for pdf report not using default engines #587

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

igorlombacx
Copy link
Contributor

@igorlombacx igorlombacx commented Sep 27, 2023

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Fix to always generate a pdf report using engines gotten on the scan if "report-pdf-options" flag value is default

image

References

https://checkmarx.atlassian.net/browse/AST-30015?atlOrigin=eyJpIjoiZTgzODI3M2VmZGNkNDgxNDgxMzlmOGIwM2IyMDRiNTAiLCJwIjoiaiJ9

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@pedrompflopes pedrompflopes requested review from a team, margaritalm and hmmachadocx and removed request for a team September 27, 2023 15:31
@github-actions github-actions bot added the bug Something isn't working label Sep 27, 2023
@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Logo
Checkmarx One – Scan Summary & Detailsc7fe7a00-7fdf-46ce-9834-88349667a993

No New Or Fixed Issues Found

@pedrompflopes pedrompflopes self-requested a review September 29, 2023 09:07
@pedrompflopes pedrompflopes merged commit 6790ba2 into main Sep 29, 2023
7 checks passed
@pedrompflopes pedrompflopes deleted the BUG/AST-30015-PDF-REPORT-FIX-ENGINES branch September 29, 2023 09:09
igorlombacx added a commit that referenced this pull request Oct 20, 2023
* fix for pdf report not using default engines

* fix for pdf report not using default engines

* Update one-scan.yml

* Update one-scan.yml

---------

Co-authored-by: Pedro Lopes <[email protected]>
ittaigilat-cx pushed a commit that referenced this pull request Jan 4, 2024
* fix for pdf report not using default engines

* fix for pdf report not using default engines

* Update one-scan.yml

* Update one-scan.yml

---------

Co-authored-by: Pedro Lopes <[email protected]>
thtri pushed a commit to thtri/ast-cli that referenced this pull request Apr 19, 2024
* fix for pdf report not using default engines

* fix for pdf report not using default engines

* Update one-scan.yml

* Update one-scan.yml

---------

Co-authored-by: Pedro Lopes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants