Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more than 10k in summary results #579

Merged
merged 18 commits into from
Sep 19, 2023

Conversation

igorlombacx
Copy link
Contributor

@igorlombacx igorlombacx commented Sep 14, 2023

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Scan summaries now support more than 10k results

References

https://checkmarx.atlassian.net/browse/AST-28846?atlOrigin=eyJpIjoiNWUzNTliMDU0N2E2NDhhMjlhYmVjNThjMzUzN2NiODEiLCJwIjoiaiJ9

Testing

Manual tests
Integration tests
Unity tests

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@pedrompflopes pedrompflopes requested review from a team, pedrompflopes and hmmachadocx and removed request for a team September 14, 2023 17:50
@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Logo
Checkmarx One – Scan Summary & Detailsdc820efa-522a-4b65-95a5-9f4ffec4b589

No New Or Fixed Issues Found

@igorlombacx igorlombacx marked this pull request as ready for review September 15, 2023 17:00
@pedrompflopes pedrompflopes requested a review from a team September 15, 2023 17:00
internal/commands/result.go Outdated Show resolved Hide resolved
internal/commands/result.go Outdated Show resolved Hide resolved
internal/commands/result.go Outdated Show resolved Hide resolved
internal/commands/result.go Outdated Show resolved Hide resolved
internal/commands/result.go Outdated Show resolved Hide resolved
internal/commands/result.go Show resolved Hide resolved
internal/commands/result.go Outdated Show resolved Hide resolved
internal/wrappers/results-http.go Outdated Show resolved Hide resolved
@igorlombacx igorlombacx merged commit e8bcd9f into main Sep 19, 2023
6 checks passed
@igorlombacx igorlombacx deleted the ENHANCEMENT/RESULTS-LIMIT-SUPPORT branch September 19, 2023 15:31
igorlombacx added a commit that referenced this pull request Oct 20, 2023
* creating a model using what we are getting from API call to /scan-summary

* models refactor

* summary refactor supporting than 10k results

* mock and linter

* refactoring, mocks, and results improvements

* linter, enhanceWithScanSummary refactored

* linter - summaryReport refactored

* setNotAvailableNumberIfZero refactored

* pr review suggestions

* linter

* integration test coverage increase
ittaigilat-cx pushed a commit that referenced this pull request Jan 4, 2024
* creating a model using what we are getting from API call to /scan-summary

* models refactor

* summary refactor supporting than 10k results

* mock and linter

* refactoring, mocks, and results improvements

* linter, enhanceWithScanSummary refactored

* linter - summaryReport refactored

* setNotAvailableNumberIfZero refactored

* pr review suggestions

* linter

* integration test coverage increase
thtri pushed a commit to thtri/ast-cli that referenced this pull request Apr 19, 2024
* creating a model using what we are getting from API call to /scan-summary

* models refactor

* summary refactor supporting than 10k results

* mock and linter

* refactoring, mocks, and results improvements

* linter, enhanceWithScanSummary refactored

* linter - summaryReport refactored

* setNotAvailableNumberIfZero refactored

* pr review suggestions

* linter

* integration test coverage increase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants