Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout and retry flags support for bitbucket, azure, github and gitlab wrappers #576

Merged
merged 24 commits into from
Sep 12, 2023

Conversation

igorlombacx
Copy link
Contributor

@igorlombacx igorlombacx commented Sep 7, 2023

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

References

https://checkmarx.atlassian.net/browse/AST-28062?atlOrigin=eyJpIjoiN2U0NWRjMjYyMGUzNGE5MzkyZDk0YWExZmFmOGNmZjciLCJwIjoiaiJ9

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@pedrompflopes pedrompflopes requested review from a team, pedrompflopes and tiagobcx and removed request for a team September 7, 2023 13:56
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Logo
Checkmarx One – Scan Summary & Details9619fdbb-1ec0-4aef-9b28-ca90bf6ccb04

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Denial_Of_Service_Resource_Exhaustion /internal/wrappers/client.go: 371 Attack Vector
MEDIUM Denial_Of_Service_Resource_Exhaustion /internal/wrappers/client.go: 561 Attack Vector
MEDIUM Denial_Of_Service_Resource_Exhaustion /internal/wrappers/client.go: 569 Attack Vector
MEDIUM Denial_Of_Service_Resource_Exhaustion /internal/wrappers/client.go: 569 Attack Vector
MEDIUM SSRF /internal/wrappers/client.go: 367 Attack Vector
MEDIUM SSRF /internal/wrappers/client.go: 371 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Denial_Of_Service_Resource_Exhaustion /internal/wrappers/github-http.go: 257
MEDIUM Denial_Of_Service_Resource_Exhaustion /internal/wrappers/github-http.go: 257
MEDIUM Denial_Of_Service_Resource_Exhaustion /internal/wrappers/gitlab-http.go: 153
MEDIUM Denial_Of_Service_Resource_Exhaustion /internal/wrappers/gitlab-http.go: 153

@igorlombacx igorlombacx changed the title Enhancement/ast 28062 timeout flag timeout flag Sep 7, 2023
@igorlombacx igorlombacx changed the title timeout flag Timeout flag support Sep 7, 2023
@igorlombacx igorlombacx changed the title Timeout flag support Timeout and retry flags support for bitbucket, azure, github and gitlab wrappers Sep 11, 2023
@igorlombacx igorlombacx marked this pull request as ready for review September 11, 2023 11:22
@pedrompflopes pedrompflopes requested a review from a team September 11, 2023 11:22
diogopcx
diogopcx previously approved these changes Sep 11, 2023
@igorlombacx igorlombacx added the enhancement New feature or request label Sep 12, 2023
@igorlombacx igorlombacx merged commit ce18723 into main Sep 12, 2023
6 checks passed
@igorlombacx igorlombacx deleted the ENHANCEMENT/AST-28062-TIMEOUT-FLAG branch September 12, 2023 13:57
igorlombacx added a commit that referenced this pull request Oct 20, 2023
…ab wrappers (#576)

* - GetWithQueryParams function to create requests with retry flag

* - refactoring client.go

* - refactoring client.go - linter

* - Adding support to custom requets in GetWithQueryParams

* - Refactoring github-http functions

* - Refactoring gitlab-http and azure-http functions

* - mistype fix
ittaigilat-cx pushed a commit that referenced this pull request Jan 4, 2024
…ab wrappers (#576)

* - GetWithQueryParams function to create requests with retry flag

* - refactoring client.go

* - refactoring client.go - linter

* - Adding support to custom requets in GetWithQueryParams

* - Refactoring github-http functions

* - Refactoring gitlab-http and azure-http functions

* - mistype fix
thtri pushed a commit to thtri/ast-cli that referenced this pull request Apr 19, 2024
…ab wrappers (Checkmarx#576)

* - GetWithQueryParams function to create requests with retry flag

* - refactoring client.go

* - refactoring client.go - linter

* - Adding support to custom requets in GetWithQueryParams

* - Refactoring github-http functions

* - Refactoring gitlab-http and azure-http functions

* - mistype fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants