feat(auth): add support for device code grant flow #5680
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/widgets/dialogs/LoginDialog.cpp
Outdated
| errors.append("Missing user ID"); | ||
| } | ||
| if (username.isEmpty()) | ||
| if (errors.length() > 0) |
There was a problem hiding this comment.
warning: the 'empty' method should be used to check for emptiness instead of 'length' [readability-container-size-empty]
| if (errors.length() > 0) | |
| if (!errors.empty()) |
Additional context
.qtinstall/Qt/6.6.2/gcc_64/include/QtCore/qlist.h:681: method 'QList'::empty() defined here
inline bool empty() const noexcept
^
|
Been running this for a few days and seems solid 👍 |
|
Should we validate that stored tokens have all of |
Twitch does that when we refresh tokens (the last time I tested it). The error you get there is pretty bad, though (iirc, it's the same one you get when the token is invalid). Should be enough to add a message with a link to re-authenticate. |
This PR adds support for Twitch's Device code grant flow (DCF). This makes it possible to (effectively) use tokens for much longer without requiring the user to reauthenticate (assuming the scopes didn't change).
Currently, this uses a client-id I created (THIS MUST BE CHANGED BEFORE A MERGE). Because we use the
publicclient type, the client-id is limited to DCF-only (as far as I understand).(effectively) closes #5169.
Here's a cool video I took in February when I started this (hasn't changed much):
firefox_2024-02-11_12-24-45.mp4