Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare autoScale as open #5202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eirikvaa
Copy link

@eirikvaa eirikvaa commented Sep 25, 2024

Goals ⚽

Open up the autoScale method so that additional operations can be performed while auto scaling.

Our usage is this:

override func autoScale() {
    super.autoScale()
    notifyDataSetChanged()
}

We have enabled auto scaling and there are additional elements in the graph that rely on notifyDataSetChanged being called. We have maintained our own fork for this sole change, but if it's not too controversial, it would be nice to merge this change upstream.

Implementation Details 🚧

Nothing special, just declare the method as open instead of internal.

Testing Details 🔍

I don't think any tests are relevant here.

@eirikvaa eirikvaa changed the title Open up the autoScale method so it can be overriden Declare autoScale as open Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants