Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move hotkey after return statement #1318

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jdb78
Copy link
Contributor

@jdb78 jdb78 commented Sep 6, 2024

Hotkey for microphone recording even gets triggered if audio input is disabled. this fixes the issue

@dokterbob
Copy link
Collaborator

Thanks for the contrib @jdb78! Code looks sensible and good to me.

Would be great to have a test for it but I imagine audio in a headless browser might be challenging. Nonetheless, if you're up for a challenge, I could leave the PR open or, to move things faster, be open to a second PR with tests for the audio feature.

In the mean time, I would appreciate feedback from other reporters to move this merge forward - our bandwidth for manual testing is limited. If I get one OK, I'm confident to approve and merge. @stephenrs @puppetm4st3r

@xandao-dev
Copy link

xandao-dev commented Oct 18, 2024

As a workaround, I have completely disabled the 'p' hotkey because it triggers the mic whenever I press 'p' in the copilot.

window.cl_shadowRootElement.addEventListener('keydown', blockPKeyEvent);
function blockPKeyEvent(event) {
      if (event.key === 'P' || event.key === 'p') {
        event.stopPropagation();
      }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants