-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement ViewDU.batchHashTreeRoot() #392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected 🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
twoeths
added a commit
that referenced
this pull request
Aug 9, 2024
wemeetagain
reviewed
Aug 19, 2024
I should have mentioned the new |
wemeetagain
approved these changes
Sep 3, 2024
this is part 1 of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
batchHashTreeRoot()
for ViewDU type based onHashComputation
Description
hashTreeRoot()
is still great because it does not allocate any memory so we need a new method to compute batchpackages/ssz/src/viewDU/abstract.ts
, addbatchHashTreeRoot()
methodHashComputationGroup
in previous PR 389commit()
method:hcByLevel
is null, it means it was called fromhashTreeRoot()
,commit()
method should be backward compatible in this casehcByLevel
, it should compute root because this ViewDU does not supportHashComputation
cherry picked from #378
Unit Tests
batchHashTreeRoot()
returns the same value tohashTreeRoot
, please suggest if we need morepart of #355